https://github.com/catlinbuckley/roll20criticalhitorfail/releases/tag/v1.2.2, I found another bug. Please review the TOS and Privacy Policy.  You could even forgo the return with something akin to:     var criticalHit = {}, I was on vacation and didn't have access to a computer. Just type !jukebox and it'll give you some options. (10,137), Water Biggest question does it differentiate between skills and attacks?  Would it be able to somehow? (3,045), Reggae

Audio Micro is absolutely an electronic product. Is it hard coded to work only for a 20 or a 1 ? And sorry for my bad english... to make it so it will play sound for rolls the GM makes but not for /gr rolls, change line 129 to:  if (!playerIsGM(msg.playerid) || !excludeGM && msg.type !== "gmrollresult") {. If you take a look at the latest code (not release), I started implementing something along those lines last night.

(182), Industrial and Machinery Download from thousands of royalty-free critical sound FX by professional sound effects producers. Updated Dynamic Lighting now does as much and even more than our legacy system! Is there a way I could tear apart this script to get it to play jukebox tracks by name? Critical failures can just have that Wah-wah-wah-waaaaa~aaaaah noise but I'd like some distinct noises for my players crit with his greatsword (slashing damage) or an arrow strike (piercing/ranged).  I write a short example for someone a few weeks ago which you might find useful to look at: on('ready',function(){ (1), Foley (7,393), Holiday BROWSE NOW >>> let comp=[];

(4), Cartoon and Comic I hope you go on to write more scripts! Setup: Install the script on Roll20, then select 2 sounds in the Jukebox. I've tried both with and removing the V1.1.1 bit but I just keep getting a syntax error. Download and buy high quality System Critical sound effects. (3,983), Children  I'll have to check that, but I think your isJson() function will always return true.         criticalFail = {}; • You might consider adding checking for crits in ranges, say for things like [[1d20cs>18]]. }); I've posted a fix that should resolve your issue. on('chat:message',function(msg){ Simple, elegant and very cool.

}); Great tit (Parus major) - springtime - alarm calling - birds in the distance with blackbird and others. Terms of Service and Privacy Policy Update. This is one of my first scripts so any feedback is appreciated. (15), Water

"SyntaxError: Unexpected end of input" Can you advise? At SoundEffects+ you find over 5000 free sound effects recorded, designed and produced by a team of our audio professionals. (1,512), Music Cues

(170), Voice Prompts and Spoken Phrases (3,771), Tools By default, the GM is excluded from these rolls (I do a lot of rolling, so it would get annoying). var isCrit = function(roll){

at /home/node/d20-api-server/node_modules/firebase/lib/firebase-node.js:93:560 BROWSE NOW >>> (1,567), Easy Listening

Long tailed tit (Aegithalos caudatus) - springtime - alarm calling - blackbird in the distance. However, if you want to include the GM, just set excludeGM to false at the top of the script. Great tit (Parus major) - springtime - alarm calling - birds in the distance. (4,384), Exteriors (2,417), Cartoons and Comic Effects Thanks for the feedback. Critical hits, also known as crits or full crits, are attacks that do extra damage and have distinctive sound effects when fired and upon hitting a target. • It's always nice to include a version number in the code, just so if you end up helping someone with it and you've made modifications you can know what one they've got.

(18), Other (Miscellaneous) I also expanded the script to allow for the shaped custom crits. }); We are here for you should you have any questions, experience a problem or just want to reach out.

All rights reserved. (72), Horror and Halloween Buildings are immune to both types (3,595), Foley

Our team owns the copyrights to all the sound effects on this website and you can safely to use them in your projects. European green woodpecker (Picus viridis) - calling in spring - gently drumming on tree trunk and birds ... European green woodpecker (Picus viridis) - alarm calling in spring - birds in distance - Croatia. (18,474), Human I just tried it out and I love it. _.each(roll.mods.customCrit,function(cc){ sendChat('isCrit',`The ${r.v} is a critical!`); at hc (/home/node/d20-api-server/node_modules/firebase/lib/firebase-node.js:39:147), Hi Thorsten, Thanks for posting the bug.

            } else if('Critical Fail' === o.get('title')){ By using our website, you agree to the Pond5 Terms of Use and Privacy Policy which includes Pond5's practices regarding personal data and cookies. (1,728), Musicbed Thanks, Z. I've committed the update you suggested so /gr rolls should be ignored if excludeGM is set. I love this idea. (1,326), Rock

New Sound Effects. However, if you want to include the GM, just set excludeGM to false at the top of the script. For more information on our use of non-essential Cookies, visit our Privacy Policy. Does this script still work as intended, ive set my gm value to false and ive tried just randomly rolling 1d20s over and over to hear the sound and it never plays. So, if I roll "normal" with query sometimes it still plays the sounds, and I think thats due to some hidden extra d20 somewhere. at Array.forEach (native) (27), Free Voice Prompts and Spoken Phrase Sounds.

Alas, it doesn't deal with more than one d20, it will crash the sandbox.